refactor(metro-config): upgrade glob@7 to glob@10
#29929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
3 tasks
byCedric
force-pushed
the
@bycedric/metro-config/upgrade-to-glob-10
branch
from
d2dd19b
to
06126c5
Compare
3 tasks
expo-bot
added
bot: suggestions
3 tasks
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
Simek
approved these changes
Jun 24, 2024
marklawlor
approved these changes
Jun 24, 2024
byCedric
added a commit
that referenced
this pull request
Jul 11, 2024
~~Blocked by #29929 # Why Split off from #29808, specific to `@expo/config-plugins` # How - Upgraded `glob@7` to `glob@10` - Added alphabetical sorting of glob results in `ios/Paths.ts` - Note, we implicitly depend on this alphabetical sorting, while glob returns the order of the file system (might vary). Probably need to be more explicit in this. - Unified `import { globSync } from 'glob'` instead of `import { sync as globsync } from 'glob'` # Test Plan See if CI and tests passes # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
byCedric
added a commit
that referenced
this pull request
Jul 11, 2024
~~Blocked by #29929 ~~Blocked by #29894 ~~Blocked by #29985 # Why - Split off from #29808, specific to `@expo/cli` - Stacked on #29894 -- there are changes in the included types in this PR # How - Upgraded `glob@7` to `glob@10` - Added tests for `glob` utilities - Added tests for timeout glob in `TypeScriptProjectPrerequisite` - Reimplemented glob utilities - Reimplemented timeout glob in `TypeScriptProjectPrerequisite` - Added missing `@types/glob` to all packages still using `glob@7` # Test Plan See if CI and tests passes # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
alanjhughes
pushed a commit
that referenced
this pull request
Jul 17, 2024
~~Blocked by #29929 # Why Split off from #29808, specific to `@expo/config-plugins` # How - Upgraded `glob@7` to `glob@10` - Added alphabetical sorting of glob results in `ios/Paths.ts` - Note, we implicitly depend on this alphabetical sorting, while glob returns the order of the file system (might vary). Probably need to be more explicit in this. - Unified `import { globSync } from 'glob'` instead of `import { sync as globsync } from 'glob'` # Test Plan See if CI and tests passes # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
alanjhughes
pushed a commit
that referenced
this pull request
Jul 17, 2024
~~Blocked by #29929 ~~Blocked by #29894 ~~Blocked by #29985 # Why - Split off from #29808, specific to `@expo/cli` - Stacked on #29894 -- there are changes in the included types in this PR # How - Upgraded `glob@7` to `glob@10` - Added tests for `glob` utilities - Added tests for timeout glob in `TypeScriptProjectPrerequisite` - Reimplemented glob utilities - Reimplemented timeout glob in `TypeScriptProjectPrerequisite` - Added missing `@types/glob` to all packages still using `glob@7` # Test Plan See if CI and tests passes # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Split off from #29808, specific to
@expo/metro-configHow
glob@7toglob@10globSyncimport toimport { globSync } from 'glob'Test Plan
See if CI and tests passes
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).