-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] fix local path paring error on ios version lower than 17 #29958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Pull Request introduced fingerprint changes against the base commit: 322106f Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "420731c5f9d0d0adc2818c2b512385ad3f725d72"
}
] Generated by PR labeler 🤖 |
This was referenced Jun 24, 2024
[iOS][expo-file-system][SDK51] Asset is not readable on iOS versions <17 in standalone build.
#29759
Closed
Thanks for the fix, @Kudo , but it doesn't work on Iphone 8, iOS 15.4. |
lukmccall
approved these changes
Jun 24, 2024
@phemonick thanks for checking that. could you help to check whether 586c84d works for you? |
Kudo
added a commit
that referenced
this pull request
Jun 24, 2024
# Why possibly fix for #29759 # How on ios < 17, the `URL(string:)` cannot parse an URL that has spaces and without scheme, it returns nil instead. before SDK 51, we used `URL(fileURLWithPath:)` instead. that's a regression from #27069. this pr tries to use the `URLComponents(string:)` as fallback for ios < 16 which supports RFC 3986 with spaces. (cherry picked from commit 0801eb3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: fingerprint changed
bot: passed checks
ExpoBot has nothing to complain about
published
Changes from the PR have been published to npm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
possibly fix for #29759
How
on ios < 17, the
URL(string:)
cannot parse an URL that has spaces and without scheme, it returns nil instead. before SDK 51, we usedURL(fileURLWithPath:)
instead. that's a regression from #27069.this pr tries to use the
URLComponents(string:)
as fallback for ios < 16 which supports RFC 3986 with spaces.Test Plan
i first tried to add an unit test for
FileSystemLegacyUtilities.getPathPermissions
. our ios-unit-test ci job is running on ios 16, so there was an expected failed test: https://github.com/expo/expo/actions/runs/9634505045/job/26570225509then revised the code to use the
convertToUrl(string:)
to fix the broken test.Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).