[ios][image-picker] Copy video file instead of moving

[tsapeta]

Why

Fixes #5321

How

Simply replaced moveItemAtURL:toURL:error with copyItemAtURL:toURL:error, as the first one throws an error due to missing permissions 🤷‍♂ Probably the temporary directory to which the compressed videos are saved is now protected in iOS 13.

Test Plan

Snack https://snack.expo.io/@tsapeta/imagepicker-from-camera-roll works as expected on iOS 13.

[esamelson]

Do we need to delete the file, or will the OS take care of this for us? We've had issues in the past with ImagePicker creating multiple copies of files in temp locations and taking up a bunch of space. Just want to make sure we aren't creating that problem again, inadvertently.

Also would advocate for not backporting this to older SDK versions unless we are planning to cherry-pick to old release branches and create new shell app bases. Otherwise this creates more confusing behavior differences between the client and shell apps (i.e. ImagePicker works on my SDK 33 project in the Expo Client, why is it suddenly failing in my standalone app?). Better to leave it alone in the Expo Client so it's clear you need to upgrade to 35 in order to fix this.

[tsapeta]

@esamelson So in terms of deleting the file, looks like in iOS 13 we're no longer able to move the file from that temporary location where these videos are saved. It throws an error - see #5321 issue.

And yeah, you're right about backporting - will revert these changes, but I'm also ok with releasing them for standalone apps.

[esamelson]

Cool, sounds good. I would only be hesitant about fixing the shell apps because it takes a fair amount of time to do properly (with testing and everything) and would prefer to invest that time into making SDK 35 better sooner instead 🙂 but we can revisit if a bunch of people ask for this fix to be backported.

Regarding the file -- I was more wondering if we should try removing it after copying it (and just ignore any errors that happen when removing)? Or do you think that's overkill and the OS will take care of clearing the temp files?

[mvjansen]

Hi, there still appears to be an issue in ImagePicker.launchImageLibraryAsync. I get the following error when I select a video: "The callback callMethod() exists in module NativeUnimoduleProxy, but only one callback may be registered to a function in a native module"

[sjchmiela]

Hey @mvjansen! Could you please create a new issue with all the details provided? This sounds like a completely different problem than the one fixed by this PR. Thanks!

[Nnoerregaard]

@mvjansen I experienced the exact same issue on iOS 13 before upgrading to expo SDK 35 (I was on SDK 33 previously).
After upgrading, the issue has disappeared

[tomelsner]

@mvjansen I had the same issue, it disappeared when updating to SDK 35. Make sure you also update "expo-image-picker": "^7.0.0" and you also have "sdkVersion": "35.0.0" set in your app.json.

[mvjansen]

Thanks for your help everyone - I'd missed updating the sdkVersion in app.json! @Nnoerregaard @tomelsner

[mikeRChambers610]

I am using Expo SDK 40 and "expo-image-picker": "~9.2.0", but still getting the issue.

When I try to pick a video, my error message is shown as below:

Possible Unhandled Promise Rejection (id: 0): Error: Could not get the image promiseMethodWrapper@http.......

[mikeRChambers610]

Upgraded to Expo SDK 41 and now using "expo-image-picker": "~10.1.4", still getting the same issue.