Fix expo-av for usage with AndroidX #5575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjchmiela
reviewed
Sep 9, 2019
Co-Authored-By: Stanisław Chmiela <sjchmiela@users.noreply.github.com>
|
Please be aware of my comment here |
|
To make it clear: This is not a migration to AndroidX, but allows you to use jetifier to make it AndroidX compatible. |
sjchmiela
pushed a commit
that referenced
this pull request
Sep 24, 2019
At the moment projects with expo-av do not compile for Android with AndroidX. The package is missing the "support-annotations" dependency in order to compile. After the change it runs fine using jettifier. Manually tested on Android Device and Simulator. Fixes #5310, #5474 and unimodules/react-native-unimodules#61
|
This should be definitely mentioned here, took me 6 hours to find this pull request https://github.com/expo/expo/tree/master/packages/expo-av |
cruzach
pushed a commit
that referenced
this pull request
Oct 2, 2019
# Why At the moment projects with expo-av do not compile for Android with AndroidX. # How The package is missing the "support-annotations" dependency in order to compile. After the change it runs fine using jettifier. # Test Plan Manually tested on Android Device and Simulator. Fixes #5310, #5474 and unimodules/react-native-unimodules#61
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
# Why At the moment projects with expo-av do not compile for Android with AndroidX. # How The package is missing the "support-annotations" dependency in order to compile. After the change it runs fine using jettifier. # Test Plan Manually tested on Android Device and Simulator. Fixes expo#5310, expo#5474 and unimodules/react-native-unimodules#61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
At the moment projects with expo-av do not compile for Android with AndroidX.
How
The package is missing the "support-annotations" dependency in order to compile. After the change it runs fine using jettifier.
Test Plan
Manually tested on Android Device and Simulator.
Fixes #5310, #5474 and unimodules/react-native-unimodules#61