Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest] Convert jest-expo-enzyme to TypeScript #5677

Merged
merged 16 commits into from
Sep 21, 2019

Conversation

EvanBacon
Copy link
Contributor

Why

Currently jest-expo-enzyme breaks in prod because it isn't compiled.

How

Convert jest-expo-enzyme to TS

Test Plan

  • unit-tests continue to pass
  • yarn pack -> copy to project outside of expo/expo -> run tests

@EvanBacon EvanBacon added the Jest with Expo Pertains to using Jest with an Expo project. label Sep 18, 2019
@EvanBacon EvanBacon requested a review from ide September 18, 2019 05:39
@EvanBacon EvanBacon self-assigned this Sep 18, 2019
Copy link
Member

@ide ide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to run yarn it seems, ci is broken

yarn.lock Outdated Show resolved Hide resolved
packages/jest-expo-enzyme/src/setupEnzyme.web.ts Outdated Show resolved Hide resolved
packages/jest-expo-enzyme/src/setupEnzyme.native.ts Outdated Show resolved Hide resolved
packages/jest-expo-enzyme/src/setupEnzyme.native.ts Outdated Show resolved Hide resolved
packages/jest-expo-enzyme/src/serializer.ts Outdated Show resolved Hide resolved
packages/jest-expo-enzyme/package.json Outdated Show resolved Hide resolved
packages/jest-expo-enzyme/src/index.ts Outdated Show resolved Hide resolved
packages/jest-expo-enzyme/src/index.ts Outdated Show resolved Hide resolved
packages/jest-expo-enzyme/src/setupEnzyme.web.ts Outdated Show resolved Hide resolved
packages/jest-expo-enzyme/tsconfig.json Show resolved Hide resolved
@EvanBacon EvanBacon merged commit bc46a12 into master Sep 21, 2019
@EvanBacon EvanBacon deleted the @evanbacon/jest-expo-enzyme/ts-migration branch September 21, 2019 01:54
cruzach pushed a commit that referenced this pull request Oct 2, 2019
* Convert jest-expo-enzyme to TypeScript

* Remove use-strict

* Update yarn.lock

* Fixed dependencies

* lint

* Update jest-preset.js

* Update package.json

* updated types

* Removed ts-ignores

* Fixed jest tests

* Update yarn.lock

* Fixed failing tests

* jest-expo-enzyme blur

* Added jest-expo-enzyme build files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jest with Expo Pertains to using Jest with an Expo project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants