-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android][navbar] allow for all Android FullScreen options #7049
Conversation
|
we should take care of updating the value in app.json automatically in |
@brentvatne good thinking 🧠will do |
Hi. This doesn't seem to work. I am quite new to this world, so I might be missing something, so be gentle... $ expo build:android -t app-bundle --release-channel android app.json.... { $ expo diagnostics Expo CLI 3.13.1 environment info: |
@alanupstone - these changes will be included in the upcoming sdk37 release |
@brentvatne - Thanks for the quick response. I'll stand down! Must be misunderstanding something I read about it being in 36.0.2 |
gotcha, yeah it'll be out soon! |
@brentvatne Is this wrong to use, then, in my package.json? |
the latest release of that package is 36.0.1: https://github.com/expo/react-native/releases |
navigator color goes back to phone color when keyboard is showing or modal is showing. |
I am extremely proud of the EXPO Team and ALL of your accomplishments. I waited long enough for the fullscreen feature to work again on Android Phones... and SDK release 37 is a phenomenal way to prove just that. ` ` Keep creating great stuff for this thriving developer community. Regards Hugo Barbosa |
Thanks for this. Though I'm trying to use "sticky-immersive" and while it works for the navigation bar, swiping never brings back the status bar. I'm on SDK 37. |
You have to make a bit more pressure on the lower part of your Android Phone and then slowly swipe up your finger on the screen and it will remain active for about 3-5 secs |
@inglesuniversal In the case I was trying this worked for the navigation bar on the botom, but not for the status bar. With "leanback" both bars would come up when touching; with "sticky-immersive" only the navbar would come up, but the status bar would not appear. I'll see if I can make a simple reproducible example. |
Immersive mode is turned off (android navigation bar sticks and doesn't hide) when soft keyboard is shown and then hidden again. There are numerous resources on this issue, but this one promises the most: |
where is this setting? |
https://docs.expo.io/workflow/configuration/#androidnavigationbar |
Guys, thank you so much for the effort. I don't know if it's just me, but this new feature doesn't seem to work how it should with |
@Mendzak if you think you've found a bug in the Expo SDK, please open an issue and follow the bug report template |
Why
Android System UI provides 3 options:
source
Currently, we let users set
androidNavigationBar.visible
to true or false. True is normal behavior, false results in Leanback option above.Proposal: allow users to use leanback, immersive, or sticky immersive.
How
Changed app.json
androidNavigationBar.visible
to accept a string, and respond based off of that.The term
visible
might not be the best description of this, since that seems to match a true/false value instead, so I'm open to suggestions on that. Maybevisibility
is more accurateTest Plan
Tested in Expo client and standalone
when making these changes to the SDK 36 branch, this affects both Navigation bar and status bar, but when working off of master it only affects navigation bar, which I believe is preferable so that users can decide on their own whether or not they want to hide both. I think this difference is due to changes in 4cb56e4
This PR expands upon the feature added in #5280
Closes #6525
Also should mark this as completed once this lands https://expo.canny.io/feature-requests/p/hide-android-bottom-buttons--fullscreen-mode