Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios][android] 🔌 Update @react-native-community/netinfo to 5.5.0 #7095

Merged
merged 4 commits into from
Feb 19, 2020

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Feb 18, 2020

Why

Part of #7006

How

  • Used et update-vendored-module to update @react-native-community/netinfo
  • Updated version of this module in home and native-component-list.
  • Refactored and adjusted NetInfo screen in native-component-list to work with this new version. It's worth noting that there have been several breaking changes.
  • Added changelog entry.

To do after merge

  • Publish dev home

Test Plan

Tested in native-component-list example.

@tsapeta tsapeta marked this pull request as ready for review February 19, 2020 07:36
@tsapeta tsapeta requested a review from ide as a code owner February 19, 2020 07:36
@tsapeta tsapeta changed the title [ios][android] Update @react-native-community/netinfo to 5.5.0 🔌 [ios][android] 🔌 Update @react-native-community/netinfo to 5.5.0 Feb 19, 2020
@tsapeta tsapeta merged commit 879ae20 into master Feb 19, 2020
@tsapeta tsapeta deleted the @tsapeta/update-netinfo branch February 19, 2020 15:12
prakashbask pushed a commit to prakashbask/expo that referenced this pull request Mar 16, 2022
…o#7095)

# Why

Part of expo#7006 

# How

- Used `et update-vendored-module` to update `@react-native-community/netinfo`
- Updated version of this module in `home` and `native-component-list`.
- Refactored and adjusted NetInfo screen in `native-component-list` to work with this new version. It's worth noting that **there have been several breaking changes**.
- Added changelog entry.

## To do after merge

- Publish dev home

# Test Plan

Tested in `native-component-list` example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant