-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expo-apple-auth] Add “Sign up with Apple” option #7471
Conversation
|
we should wait until after sdk 37 is released before merging this because we don't want to pull the docs changes in here from unversioned to 37 |
The iOS build is currently failing because the new
I think we need to upgrade XCode on the build server, What do you think @sjchmiela ? |
@nicknovitski would you be able to help out with upgrading Xcode in CI, when you get a chance? for this PR we need at least Xcode 11.2. |
@IjzerenHein I've upgraded Xcode on the CI to 11.4.0 (#7316), it's not merged yet but should be soon 😉 EDIT: it landed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but please add changelog (packages/expo-apple-authentication/CHANGELOG.md
) entry as well 🙏
packages/expo-apple-authentication/src/AppleAuthentication.types.ts
Outdated
Show resolved
Hide resolved
Thanks for making this happen, guys. It wasn't that long ago when I reported this so I really appreciate the quick turnaround. 🙏 |
3412f5b
to
576d77e
Compare
Hi, @IjzerenHein. Should this be part of the recently-released export declare enum AppleAuthenticationButtonType {
SIGN_IN = 0,
CONTINUE = 1
} Am I missing something? Thank you. |
Hi Darryl. No this has not been released yet. |
Got it. Thanks anyway. Have a good week. ✌️ |
Hi again, @IjzerenHein. Will this be released at some point soon? Thanks! |
Yep this will be released in SDK 38 which is just about to enter QA and testing. Not sure what the exact release date will be, but should be within a couple weeks max |
Great. Thank you, @IjzerenHein. Much appreciated. |
Hey all. Is there a good way to test the configuration for Sign in with Apple through the Expo app on iOS? I tried calling the https://appleid.apple.com/auth/token endpoint to get access & refresh token, but I keep getting Thanks! |
Why
Add support for "Sign up with Apple" to
expo-apple-authentication
.This option was added by Apple in iOS 13.2, but wasn't available to our users yet.
How
Added this option to the
expo-apple-authentication
package. As well as the NCL and to the docs.Renders an empty view when used on iOS 13.1 or lower.
Test Plan
New option has been added to the NCL test app:
Because this option is only available on iOS 13.2, running this on a lower iOS version will render an empty view (screenshot is from iOS 13.1):
Other
Fixes #7454