[linear-gradient] Migrate to functional components #8673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
ide
requested changes
Jun 6, 2020
packages/expo-linear-gradient/src/NativeLinearGradient.android.tsx
Outdated
Show resolved
Hide resolved
packages/expo-linear-gradient/src/NativeLinearGradient.android.tsx
Outdated
Show resolved
Hide resolved
packages/expo-linear-gradient/src/NativeLinearGradient.android.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: James Ide <ide@users.noreply.github.com>
ide
approved these changes
Jun 7, 2020
EvanBacon
deleted the
@evanbacon/linear-gradient/migrate-to-functional-components
branch
esamelson
pushed a commit
that referenced
this pull request
Jun 24, 2020
* Remove index re-export * Created shim element for unsupported platforms * Convert LinearGradient to functional component * Convert all react imports to star imports * Unify types and add doc blocks * Update NativeLinearGradient.web.tsx * Updated build files * Updated docs for linear gradient * Update linear-gradient.md * Update CHANGELOG.md * Use nullish * Clean up function export * Apply suggestions from code review Co-authored-by: James Ide <ide@users.noreply.github.com> * Updated docs Co-authored-by: James Ide <ide@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
LinearGradienPoint->LinearGradientPoint(breaking)Test Plan