Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[store-review][chore] Clean up docs and dependencies #8714

Merged
merged 10 commits into from
Jun 16, 2020

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Jun 7, 2020

Why

  • doc blocks were broken - using a single /* instead of /**
  • kinda confusing how this package was different from the concept of "App store review"
  • move unimodulePeerDependencies to peerDependencies
  • use expo-linking and @unimodules/core

How

  • Added preview image to docs page.
  • fixed doc blocks.
  • change default native module to a plain JS object.

@EvanBacon EvanBacon requested a review from ide June 7, 2020 20:12
@EvanBacon EvanBacon self-assigned this Jun 7, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2020

Native Component List for this branch is ready

packages/expo-store-review/src/ExpoStoreReview.ts Outdated Show resolved Hide resolved
packages/expo-store-review/src/StoreReview.ts Outdated Show resolved Hide resolved
packages/expo-store-review/src/StoreReview.ts Outdated Show resolved Hide resolved
EvanBacon and others added 2 commits June 7, 2020 21:35
Co-authored-by: James Ide <ide@users.noreply.github.com>
Co-authored-by: James Ide <ide@users.noreply.github.com>
@EvanBacon EvanBacon marked this pull request as ready for review June 11, 2020 02:16
@EvanBacon EvanBacon requested a review from tsapeta as a code owner June 11, 2020 02:16
docs/pages/versions/unversioned/sdk/storereview.md Outdated Show resolved Hide resolved
@ide
Copy link
Member

ide commented Jun 11, 2020

Before merging:

🔍 Checking the expo-store-review package ...
🏃‍♀️ Running `yarn clean` ...
🏃‍♀️ Running `yarn build` ...
The following build files need to be rebuilt and committed:
build/ExpoStoreReview.android.d.ts
build/ExpoStoreReview.android.js
build/ExpoStoreReview.android.js.map
build/ExpoStoreReview.web.d.ts
build/ExpoStoreReview.web.js
build/ExpoStoreReview.web.js.map

EvanBacon and others added 2 commits June 12, 2020 13:37
Co-authored-by: James Ide <ide@users.noreply.github.com>
@EvanBacon EvanBacon merged commit e301fa7 into master Jun 16, 2020
@EvanBacon EvanBacon deleted the @evanbacon/store-review/clean-up branch June 16, 2020 01:34
esamelson pushed a commit that referenced this pull request Jun 24, 2020
* Clean up docs and dependencies

* Update packages/expo-store-review/src/StoreReview.ts

Co-authored-by: James Ide <ide@users.noreply.github.com>

* Update packages/expo-store-review/src/StoreReview.ts

Co-authored-by: James Ide <ide@users.noreply.github.com>

* Update packages/expo-store-review/src/ExpoStoreReview.ts

* Update StoreReview.ts

* updated build files

* Update CHANGELOG.md

* Update docs/pages/versions/unversioned/sdk/storereview.md

Co-authored-by: James Ide <ide@users.noreply.github.com>

* Delete old files

Co-authored-by: James Ide <ide@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants