[splash-screen][iOS] Remove flicker in-between Splash & ReactApp #8739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
sjchmiela
reviewed
Jun 9, 2020
packages/expo-splash-screen/ios/EXSplashScreen/EXSplashScreenController.m
Outdated
Show resolved
Hide resolved
packages/expo-splash-screen/ios/EXSplashScreen/EXSplashScreenController.m
Outdated
Show resolved
Hide resolved
packages/expo-splash-screen/ios/EXSplashScreen/EXSplashScreenController.m
Show resolved
Hide resolved
tsapeta
approved these changes
Jul 9, 2020
… React App phases
bbarthec
force-pushed
the
@bbarthec/splash-screen-ios-handle-rctrootview-loadingview
branch
from
b9b5ad8
to
a807319
Compare
bbarthec
changed the title
bbarthec
deleted the
@bbarthec/splash-screen-ios-handle-rctrootview-loadingview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Flicker was reported on iOS in-between SplashScreen and ReactApp phases: https://expo-developers.slack.com/archives/C04Q3JTSV/p1591378610268800
How
Native SplashScreen View was added in
asyncmanner and that was causing some small gap while actual iOS Launch Screen was already hidden and custom view fromexpo-splash-screenwas not yet added properly.I've changed that to
syncmanner and also added handlingRCTRootView.loadingViewas described in https://reactnative.dev/docs/running-on-device#pro-tips.Moreover added proper resizing of the UIView coming from
.xibfile.Test Plan
Installed in
bare-expoand step by step debugged view hierarchy breakpointing between SplashScreen-related functions.Changelog