[web] Directly import createElement #8773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🛠 Suggested fixes:📋 Missing changelogApply suggested changes:diff --git a/packages/expo-gl/CHANGELOG.md b/packages/expo-gl/CHANGELOG.md
index be43473b..2ee984a9 100644
--- a/packages/expo-gl/CHANGELOG.md
+++ b/packages/expo-gl/CHANGELOG.md
@@ -10,6 +10,8 @@
### 🐛 Bug fixes
+- [web] Directly import createElement. ([#8773](https://github.com/expo/expo/pull/8773) by [@EvanBacon](https://github.com/EvanBacon))
+
## 8.3.1 — 2020-05-29
*This version does not introduce any user-facing changes.* |
|
Native Component List for this branch is ready |
EvanBacon
requested review from
bbarthec,
lukmccall,
mczernek and
tsapeta
as code owners
bbarthec
reviewed
Jun 15, 2020
lukmccall
reviewed
Jun 15, 2020
tsapeta
approved these changes
Jun 15, 2020
| @@ -7,12 +7,13 @@ | |||
| ### 🎉 New features | |||
|
|
|||
| - [av] Delete `prop-types` in favor of TypeScript. ([#8679](https://github.com/expo/expo/pull/8679) by [@EvanBacon](https://github.com/EvanBacon)) | |||
| - [av] Directly import `createElement` from `react-native-web` for RNW v12 support. ([#8773](https://github.com/expo/expo/pull/8773) by [@EvanBacon](https://github.com/EvanBacon)) | |||
There was a problem hiding this comment.
I think we don't need to prefix entries by the package name like [av] 🤔 That's kinda obvious they refer to that package. Also, the script that merges changelog into SDK changelog groups them by package like here: https://github.com/expo/expo/blob/master/CHANGELOG.md#-bug-fixes-1
Suggested change
| - [av] Directly import `createElement` from `react-native-web` for RNW v12 support. ([#8773](https://github.com/expo/expo/pull/8773) by [@EvanBacon](https://github.com/EvanBacon)) | |
| - Directly import `createElement` from `react-native-web` for RNW v12 support. ([#8773](https://github.com/expo/expo/pull/8773) by [@EvanBacon](https://github.com/EvanBacon)) |
There was a problem hiding this comment.
the changelog danger script added the prefix
lukmccall
approved these changes
Jun 15, 2020
EvanBacon
deleted the
@evanbacon/react-native-web/direct-import-create-element
branch
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
* Directly import createElement to avoid name change issue in react-native-web@0.12 * Update CHANGELOG.md * Update CHANGELOG.md
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
* Directly import createElement to avoid name change issue in react-native-web@0.12 * Update CHANGELOG.md * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createElement.