Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Directly import createElement #8773

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/expo-av/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@
### 🎉 New features

- [av] Delete `prop-types` in favor of TypeScript. ([#8679](https://github.com/expo/expo/pull/8679) by [@EvanBacon](https://github.com/EvanBacon))
- [av] Directly import `createElement` from `react-native-web` for RNW v12 support. ([#8773](https://github.com/expo/expo/pull/8773) by [@EvanBacon](https://github.com/EvanBacon))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to prefix entries by the package name like [av] 🤔 That's kinda obvious they refer to that package. Also, the script that merges changelog into SDK changelog groups them by package like here: https://github.com/expo/expo/blob/master/CHANGELOG.md#-bug-fixes-1

Suggested change
- [av] Directly import `createElement` from `react-native-web` for RNW v12 support. ([#8773](https://github.com/expo/expo/pull/8773) by [@EvanBacon](https://github.com/EvanBacon))
- Directly import `createElement` from `react-native-web` for RNW v12 support. ([#8773](https://github.com/expo/expo/pull/8773) by [@EvanBacon](https://github.com/EvanBacon))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changelog danger script added the prefix


### 🐛 Bug fixes

## 8.2.1 — 2020-05-29

*This version does not introduce any user-facing changes.*
_This version does not introduce any user-facing changes._
lukmccall marked this conversation as resolved.
Show resolved Hide resolved

## 8.2.0 — 2020-05-27

Expand Down
2 changes: 1 addition & 1 deletion packages/expo-av/build/ExponentVideo.web.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/expo-av/build/ExponentVideo.web.js.map

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion packages/expo-av/src/ExponentVideo.web.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as React from 'react';
import { View, createElement } from 'react-native';
import { View } from 'react-native';
import createElement from 'react-native-web/dist/exports/createElement';

import { AVPlaybackNativeSource, AVPlaybackStatus, AVPlaybackStatusToSet } from './AV';
import ExponentAV from './ExponentAV';
Expand Down
3 changes: 2 additions & 1 deletion packages/expo-camera/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@
### 🎉 New features

- Delete `prop-types` in favor of TypeScript. ([#8680](https://github.com/expo/expo/pull/8680) by [@EvanBacon](https://github.com/EvanBacon))
- [camera] Directly import `createElement` from `react-native-web` for RNW v12 support. ([#8773](https://github.com/expo/expo/pull/8773) by [@EvanBacon](https://github.com/EvanBacon))

### 🐛 Bug fixes

## 8.3.1 — 2020-05-29

*This version does not introduce any user-facing changes.*
_This version does not introduce any user-facing changes._
lukmccall marked this conversation as resolved.
Show resolved Hide resolved

## 8.3.0 — 2020-05-27

Expand Down
3 changes: 2 additions & 1 deletion packages/expo-camera/build/ExponentCamera.web.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/expo-camera/build/ExponentCamera.web.js.map

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion packages/expo-camera/src/ExponentCamera.web.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React, { forwardRef } from 'react';
import { createElement, findNodeHandle, StyleSheet, View } from 'react-native';
import { findNodeHandle, StyleSheet, View } from 'react-native';
import createElement from 'react-native-web/dist/exports/createElement';

import {
CameraCapturedPicture,
Expand Down
3 changes: 1 addition & 2 deletions packages/expo-gl/build/Canvas.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/expo-gl/build/Canvas.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/expo-gl/build/createElement.native.d.ts

This file was deleted.

2 changes: 0 additions & 2 deletions packages/expo-gl/build/createElement.native.js

This file was deleted.

1 change: 0 additions & 1 deletion packages/expo-gl/build/createElement.native.js.map

This file was deleted.

1 change: 0 additions & 1 deletion packages/expo-gl/build/createElement.web.d.ts

This file was deleted.

4 changes: 0 additions & 4 deletions packages/expo-gl/build/createElement.web.js

This file was deleted.

1 change: 0 additions & 1 deletion packages/expo-gl/build/createElement.web.js.map

This file was deleted.

4 changes: 1 addition & 3 deletions packages/expo-gl/src/Canvas.tsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import * as React from 'react';
import { findDOMNode } from 'react-dom';
import { LayoutChangeEvent, PixelRatio, StyleSheet, View, ViewProps } from 'react-native';

// @ts-ignore
import { createElement } from './createElement';
import createElement from 'react-native-web/dist/exports/createElement';

function getElement(component) {
try {
Expand Down
1 change: 0 additions & 1 deletion packages/expo-gl/src/createElement.native.tsx

This file was deleted.

4 changes: 0 additions & 4 deletions packages/expo-gl/src/createElement.web.tsx

This file was deleted.

2 changes: 1 addition & 1 deletion packages/html-elements/build/elements/Rules.web.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/html-elements/build/elements/Rules.web.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/html-elements/build/elements/Table.web.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.