[menu-bar] Improve popover height calculations when using multiple displays #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We always had issues with resizing the Popover height accurately, but after upgrading react-native-macos to 0.73 this has become more apparent, often cropping the "Quit" button on the UI
How
In react-native-macos to 0.73
Dimensions.get('screen')
no longer returns the actual screen size on the first few renders (microsoft/react-native-macos@d1ed53d), so instead of relying on multiple retries this PR refactoruseSafeDisplayDimensions
to not use the Dimensions API.By exporting the initial screen size as a constant in MenuBarModule and including the screen size in the body of the
popoverFocused
event we can ensure that the screen size data is always up to date.Test Plan