Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some build and running issues #69

Merged
merged 9 commits into from
Oct 3, 2023
Merged

Fix some build and running issues #69

merged 9 commits into from
Oct 3, 2023

Conversation

douglowder
Copy link
Contributor

Why

  • Could not build on my desktop because I run Node 20
  • CLI would not work correctly without fixes in simctl.ts and xcrun.ts
  • File picker in menu bar would not work without adding await and removing file extensions

How

  • Fixed the issues
  • Added some steps in CONTRIBUTING.md

Test Plan

  • Existing CI should pass

gabrieldonadel
gabrieldonadel reviewed Oct 1, 2023
View reviewed changes
apps/menu-bar/src/modules/FilePickerModule.ts Outdated Show resolved Hide resolved
apps/cli/src/index.ts Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
gabrieldonadel
gabrieldonadel approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@gabrieldonadel gabrieldonadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question

apps/menu-bar/src/popover/Core.tsx Show resolved Hide resolved
@douglowder douglowder merged commit fb6790f into main Oct 3, 2023
1 check passed
gabrieldonadel
gabrieldonadel reviewed Oct 13, 2023
View reviewed changes
apps/menu-bar/macos/ExpoMenuBar-macOS/FilePicker.m
if (utType) {
[allowedTypes addObject:utType];
}
NSArray *utTypes = [UTType typesWithTag:extension tagClass:UTTagClassFilenameExtension conformingToType:nil];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that this does not work for APKs \

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed here #76

@gabrieldonadel gabrieldonadel deleted the doug/build-fixes branch October 13, 2023 18:31
@gabrieldonadel gabrieldonadel mentioned this pull request Oct 13, 2023
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldonadel gabrieldonadel gabrieldonadel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douglowder @gabrieldonadel