Fix connectActionSheet to exclude ActionSheetProps from return type #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for merging it! |
|
I'm sorry it took so long 🤕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modification addresses an issue where react-navigation does not accept Screen components with props other than route and navigation, creating a problem since Screen components passing through connectActionSheet demand the showActionSheetWithOptions prop as dictated by ActionSheetProps.
The value of showActionSheetWithOptions defined in ActionSheetProps is already set within the connectActionSheet function, rendering it unnecessary in the return type. By removing ActionSheetProps from the function's output, we prevent the passing of redundant props and streamline the type definition of components involved.