This repository has been archived by the owner on Apr 7, 2023. It is now read-only.
fetch manifest in turtle-cli #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
force-pushed
the
@wkozyra95/fetch-manifest-in-turtle-cli
branch
from
a9d13cd
to
2ae8452
Compare
dsokal
approved these changes
Jun 12, 2019
| @@ -75,12 +75,12 @@ async function runShellAppBuilder( | |||
|
|
|||
| logger.info({ buildPhase: 'resolve native modules' }, 'Resolving universal modules dependencies'); | |||
| const enabledModules = semver.satisfies(sdkVersion, '>= 33.0.0') | |||
| ? await resolveNativeModules(workingDir, manifest && manifest.dependencies) | |||
| ? await resolveNativeModules(workingDir, _.get(manifest, 'dependencies')) | |||
There was a problem hiding this comment.
That change doesn't really change anything :P
Co-Authored-By: Dominik Sokal <dominiksokal@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
For turtle-cli builds manifest was fetched by xdl, so when unimodules were resolved it was not available