regression fix listbuilder controls aren't sized as requested

exponentcms · Dec 1, 2018 · 52fce1a · 52fce1a
1 parent 0ac864c
commit 52fce1a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/framework/core/forms/controls/bootstrap3/listbuildercontrol.php b/framework/core/forms/controls/bootstrap3/listbuildercontrol.php
@@ -54,7 +54,7 @@ function controlToHTML($name, $label, $process = null) {
 		$this->process = $process;
 
 		if (!$this->newList) {
-			$html = "<select name='".$name."[]' id='$name' class=\"form-control\" multiple='multiple'>";
+			$html = "<select name='".$name."[]' id='$name' class=\"form-control\" multiple='multiple' size='$this->size'>";
             $list = $this->default + $this->source;
 			foreach ($list as $key=>$value) {
 				$html .= "<option value='$key'";

diff --git a/framework/core/forms/controls/bootstrap4/listbuildercontrol.php b/framework/core/forms/controls/bootstrap4/listbuildercontrol.php
@@ -53,7 +53,7 @@ function controlToHTML($name, $label, $process = null) {
 		$this->process = $process;
 
 		if (!$this->newList) {
-			$html = "<select name='".$name."[]' id='$name' class=\"form-control\" multiple='multiple'>";
+			$html = "<select name='".$name."[]' id='$name' class=\"form-control\" multiple='multiple' size='$this->size'>";
             $list = $this->default + $this->source;
 			foreach ($list as $key=>$value) {
 				$html .= "<option value='$key'";

diff --git a/framework/core/forms/controls/jquery/listbuildercontrol.php b/framework/core/forms/controls/jquery/listbuildercontrol.php
@@ -54,7 +54,7 @@ function controlToHTML($name, $label, $process = null) {
 		$this->process = $process;
 
 		if (!$this->newList) {
-			$html = "<div class=\"".(bs3()?"help-block":"control-desc")."\"></div><select name='".$name."[]' id='$name' class=\"form-control\" multiple='multiple'>";
+			$html = "<div class=\"".(bs3()?"help-block":"control-desc")."\"></div><select name='".$name."[]' id='$name' class=\"form-control\" multiple='multiple' size='$this->size'>";
             $list = $this->default + $this->source;
 			foreach ($list as $key=>$value) {
 				$html .= "<option value='$key'";