Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mobile phone locale options (#772) #776

Merged

Conversation

jeduardocosta
Copy link
Contributor

This pull request updates the mobile phone locale by adding the `pt-BR' option, as the validator.js library already has this option for use.

Resolves #772

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cf2e31b on jeduardocosta:mobilephone-locale-options into 6e8e521 on express-validator:master.

Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the 2 months delay 🙉

I reverted the test as it's not responsibility of express-validator to have its logic correct.

@gustavohenke gustavohenke merged commit 81d6542 into express-validator:master Nov 22, 2019
@gustavohenke
Copy link
Member

Shipped in v6.3.0!

@lock
Copy link

lock bot commented Jan 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide the 'pt-BR' mobile phone locale option
3 participants