Added res.cookie() maxAge support

expressjs · Mar 3, 2011 · 4c274c5 · 4c274c5
1 parent 5581ca2
commit 4c274c5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/response.js b/lib/response.js
@@ -241,20 +241,29 @@ res.clearCookie = function(name){
 };
 
 /**
- * Set cookie `name` to `val`.
+ * Set cookie `name` to `val`, with the given `options`.
+ *
+ * Options:
+ *
+ *    - `maxAge`   max-age in milliseconds, converted to `expires`
  *
  * Examples:
  *
  *    // "Remember Me" for 15 minutes
  *    res.cookie('rememberme', '1', { expires: new Date(Date.now() + 900000), httpOnly: true });
  *
+ *    // save as above
+ *    res.cookie('rememberme', '1', { maxAge: 900000, httpOnly: true })
+ *
  * @param {String} name
  * @param {String} val
  * @param {Options} options
  * @api public
  */
 
 res.cookie = function(name, val, options){
+  options = options || {};
+  if ('maxAge' in options) options.expires = new Date(Date.now() + options.maxAge);
   var cookie = utils.serializeCookie(name, val, options);
   this.header('Set-Cookie', cookie);
 };

diff --git a/test/response.test.js b/test/response.test.js
@@ -527,7 +527,7 @@ module.exports = {
       res.cookie('something', 'else');
       res.redirect('/');
     });
-    
+
     assert.response(app,
       { url: '/' },
       function(res){