Fixed app.set() with undefined

expressjs · Dec 15, 2011 · 7d24c2b · 7d24c2b
1 parent b4ce57c
commit 7d24c2b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/application.js b/lib/application.js
@@ -332,7 +332,7 @@ app.is = function(type, fn){
  */
 
 app.set = function(setting, val){
-  if (val === undefined) {
+  if (1 == arguments.length) {
     if (this.settings.hasOwnProperty(setting)) {
       return this.settings[setting];
     } else if (this.parent) {

diff --git a/test/config.js b/test/config.js
@@ -8,6 +8,11 @@ describe('config', function(){
       var app = express();
       app.set('foo', 'bar').should.equal(app);
     })
+
+    it('should return the app when undefined', function(){
+      var app = express();
+      app.set('foo', undefined).should.equal(app);
+    })
   })
 
   describe('.get()', function(){