Cookie expires now using Date#toGMTString()

Spec I found wanted hyphens, but this appears to be the norm for JS cookies
expressjs · Apr 7, 2010 · a318ef2 · a318ef2
1 parent 8ed24de
commit a318ef2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/lib/express/plugins/cookie.js b/lib/express/plugins/cookie.js
@@ -37,10 +37,7 @@ exports.compileCookie = function(name, val, options) {
   if (!options) return name + '=' + val
   return name + '=' + val + '; ' + options.map(function(val, key){
     if (val instanceof Date)
-      val = val.toString()
-        .replace(/^(\w+)/, '$1,')
-        .replace(/(\w+) (\d+) (\d+)/, '$2-$1-$3')
-        .replace(/GMT.*$/, 'GMT')
+      val = val.toGMTString()
     return val === true ? key : key + '=' + val
   }).join('; ')
 }

diff --git a/spec/spec.plugins.cookie.js b/spec/spec.plugins.cookie.js
@@ -23,7 +23,7 @@ describe 'Express'
           path: '/foo',
           domain: '.vision-media.ca'
         }
-        compileCookie('foo', 'bar', options).should.eql 'foo=bar; expires=Mon, 25-May-1987 11:13:00 GMT; path=/foo; domain=.vision-media.ca'
+        compileCookie('foo', 'bar', options).should.eql 'foo=bar; expires=Mon, 25 May 1987 18:13:00 GMT; path=/foo; domain=.vision-media.ca'
       end
 
       it 'should convert true to a key without a value'