perf: isolate app.render try block

expressjs · Jun 20, 2015 · f5a2406 · f5a2406
1 parent 1050248
commit f5a2406
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/History.md b/History.md
@@ -66,6 +66,7 @@ unreleased
     - perf: reduce try block size
     - perf: remove bitwise operations
   * perf: enable strict mode
+  * perf: isolate `app.render` try block
   * perf: remove argument reassignments in application
   * perf: remove argument reassignments in `View`
   * perf: use saved reference to `http.STATUS_CODES`

diff --git a/lib/application.js b/lib/application.js
@@ -589,11 +589,7 @@ app.render = function render(name, options, callback) {
   }
 
   // render
-  try {
-    view.render(renderOptions, done);
-  } catch (err) {
-    done(err);
-  }
+  tryRender(view, renderOptions, done);
 };
 
 /**
@@ -633,3 +629,16 @@ function logerror(err) {
   /* istanbul ignore next */
   if (this.get('env') !== 'test') console.error(err.stack || err.toString());
 }
+
+/**
+ * Try rendering a view.
+ * @private
+ */
+
+function tryRender(view, options, callback) {
+  try {
+    view.render(options, callback);
+  } catch (err) {
+    callback(err);
+  }
+}