Skip to content

Commit

Permalink
perf: isolate app.render try block
Browse files Browse the repository at this point in the history
  • Loading branch information
dougwilson committed Jun 20, 2015
1 parent 1050248 commit f5a2406
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 5 deletions.
1 change: 1 addition & 0 deletions History.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ unreleased
- perf: reduce try block size
- perf: remove bitwise operations
* perf: enable strict mode
* perf: isolate `app.render` try block
* perf: remove argument reassignments in application
* perf: remove argument reassignments in `View`
* perf: use saved reference to `http.STATUS_CODES`
Expand Down
19 changes: 14 additions & 5 deletions lib/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -589,11 +589,7 @@ app.render = function render(name, options, callback) {
}

// render
try {
view.render(renderOptions, done);
} catch (err) {
done(err);
}
tryRender(view, renderOptions, done);
};

/**
Expand Down Expand Up @@ -633,3 +629,16 @@ function logerror(err) {
/* istanbul ignore next */
if (this.get('env') !== 'test') console.error(err.stack || err.toString());
}

/**
* Try rendering a view.
* @private
*/

function tryRender(view, options, callback) {
try {
view.render(options, callback);
} catch (err) {
callback(err);
}
}

0 comments on commit f5a2406

Please sign in to comment.