Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some test files fail if I run them seperately #4797

Closed
rishabh-arya95 opened this issue Jan 27, 2022 · 0 comments
Closed

Some test files fail if I run them seperately #4797

rishabh-arya95 opened this issue Jan 27, 2022 · 0 comments
Labels

Comments

@rishabh-arya95
Copy link

rishabh-arya95 commented Jan 27, 2022

I was doing local development, If I execute some test files separately they fail with TypeError exception

example:

 app
   .engine(ext, fn)
     1) should map a template engine


 0 passing (12ms)
 1 failing

 1) app
      .engine(ext, fn)
        should map a template engine:
    Uncaught TypeError: Cannot read property 'equal' of undefined
     at /private/tmp/express/test/app.engine.js:25:20
     at /private/tmp/express/test/app.engine.js:10:5
     at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:73:3)

I see should has not been imported in some files so that is the reason, it would we better if we import it in the test files wherever required and not make files dependent on each other.

@rishabh-arya95 rishabh-arya95 changed the title Some test files fail, if I run them seperately Some test files fail if I run them seperately Jan 27, 2022
dougwilson added a commit that referenced this issue Feb 2, 2022
himanshiLt pushed a commit to himanshiLt/express that referenced this issue Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants