Adds support for replacer in json/jsonp calls #2098
Conversation
* `lib/response.js`: Updated `res.json` and `res.jsonp` to accept optional replaced, updated doc * `test/res.json.js`: Added test cases for (object, replacer), (status, object, replacer) and (object, status, replacer) * `test/res.jsonp.js`: Added test cases for (object, replacer), (status, object, replacer) and (object, status, replacer)
* `test/res.json.js`: Call `json` and not `jsonp`. Copy-paste side effects
| @@ -161,28 +161,40 @@ res.send = function(body){ | |||
| * res.json({ user: 'tj' }); | |||
| * res.json(500, 'oh noes!'); | |||
| * res.json(404, 'I dont have that'); | |||
| * res.json({ user: {id: 'id01', pwd: 'pass'}, id: 'id01', name: 'gvaish' }, ['id', 'name']); | |||
There was a problem hiding this comment.
Do not add your GitHub username to our examples, please.
|
Updated the example to remove my username to something generic. |
|
@gvaish thanks, but your username is still there in the second example. |
|
Grrr... my bad. Fixed that too. :-) |
| if ('number' == typeof replacer) { | ||
| this.statusCode = replacer; | ||
| replacer = arguments[2]; | ||
| } else if('number' == typeof obj) { |
|
i just don't like how complex it makes the function due to all the type checking. very little people use this as well. why not just stringify it yourself? |
|
Agree to the "type checking" point. But that's primarily because of supporting Point here is - in general, the core APIs surface content (model) while the end-points (controller) filter out the content. |
|
@jonathanong @dougwilson - Any luck (for this PR to make it through)? |
|
Up to the others if they want to merge it. I'm -1 because it's complex and wouldn't be used very often by most people |
|
+1 |
|
What is the point of this?
|
|
@gvaish wants to use the replacer function to sort the keys in the resulting JSON, but doesn't want to do it for all requests for some reason. This doesn't particularly sound like a valid use for the replacer function, anyway, because you cannot sort the top-level object keys with it, let alone guarantee any key ordering for sub-objects since the ECMAscript spec does not guarantee key order (but you can make it look like it if you return an object where the keys where inserted alphabetically since currently v8 will return keys in insertion order). The replacer function is only to return altered values or to omit values, it cannot technically be used to sort property keys in objects. |
See #2097