-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracing capabilities to Express #2437
Commits on Aug 26, 2016
-
* app.instrument * app._callTracers * res.trace
Configuration menu - View commit details
-
Copy full SHA for 7762e31 - Browse repository at this point
Copy the full SHA 7762e31View commit details -
add trace capabilities to express
* allow to add tracer to the app level * activate tracer from the response object
Configuration menu - View commit details
-
Copy full SHA for 94c12a8 - Browse repository at this point
Copy the full SHA 94c12a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1526713 - Browse repository at this point
Copy the full SHA 1526713View commit details -
improve _callTracers function performances
_callTrackers runs a for loop on the application tracer list. Because tracing should impact performances as least as possible, this commit optimizes this for loop. Opitimization performed: * Usage of traditional for loop instead of forEach * Caching of tracer array length that is used to test the end of the loop. Here are the benchmarks that inspired these optimizations: * http://jsperf.com/array-foreach-vs-for-loop * http://jsperf.com/for-vs-foreacay
Configuration menu - View commit details
-
Copy full SHA for 46a6469 - Browse repository at this point
Copy the full SHA 46a6469View commit details -
change call arguments of instrument tracer.
Tracers instrumented at application level now handles a single option object as argument.
Configuration menu - View commit details
-
Copy full SHA for 38ee25b - Browse repository at this point
Copy the full SHA 38ee25bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc978b7 - Browse repository at this point
Copy the full SHA fc978b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2abd43c - Browse repository at this point
Copy the full SHA 2abd43cView commit details -
link subapp tracer to parent tracer
The operation is performed when the subapp is mounted on the parent app. A tracer that calls the parent tracers is added to the sub app.
Configuration menu - View commit details
-
Copy full SHA for 786785b - Browse repository at this point
Copy the full SHA 786785bView commit details
Commits on Nov 11, 2016
-
Proper usage of supertest expect in tracing tests
Supertest lib provides a method called expect to test the result of a request. This method requires a callback that takes an error object as first parametr. If this error object is not inspected, the validation performed by expect are not checked. Tracing tests didn't do that checking. This commit add checking to trace tests to ensure that no error is returned when expect method is called.
Configuration menu - View commit details
-
Copy full SHA for f48f54b - Browse repository at this point
Copy the full SHA f48f54bView commit details -
Configuration menu - View commit details
-
Copy full SHA for aed9cb2 - Browse repository at this point
Copy the full SHA aed9cb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b7ee9c - Browse repository at this point
Copy the full SHA 6b7ee9cView commit details -
Private methods do not need to be tested
Configuration menu - View commit details
-
Copy full SHA for 72b57ae - Browse repository at this point
Copy the full SHA 72b57aeView commit details