tests: use supertest to check response header values #2992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| res.headers.should.not.have.property('x-success'); | ||
| done(); | ||
| }); | ||
| .expect(utils.shouldNotHaveHeader('X-Success')) |
There was a problem hiding this comment.
Indeed :) Fixed now :O
|
Very nice 👍 |
dougwilson
force-pushed
the
tests-no-headers-should
branch
from
f940b7c
to
ff8769c
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative pull request for #2983 converting the usages to use
supertestrather than continuing to usesupertest. This helps align with goals like removing theshouldmodule from tests eventually, since there are no lessshouldusages (plus,supertestprovides these features).The cause for these two pull requests is that there is discussion going on currently to change the prototype of the
headersobject fromObjecttonull, which would remove global extension properties like.should.