Remove unneeded array-flatten dependency #4707
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in 2015, express had its own ~9 line
flatten()
function, which got replaced by an external library in #2682 and #2624That was just before the
left-pad
fiasco in 2016, when dependencies were a magical source of free code that someone else maintains who never gets hacked, bought-off, or becomes malicious ;)https://owasp.org/Top10/A06_2021-Vulnerable_and_Outdated_Components/
https://en.wikipedia.org/wiki/Npm_(software)#Notable_breakages
This PR restores the old flatten function (we still have the test!) and removes the need for the external array-flatten dependency.