Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore settings on Object.prototype #4803

Merged

Conversation

EvanHahn
Copy link
Contributor

@EvanHahn EvanHahn commented Feb 3, 2022

Before:

app.get('hasOwnProperty');
// => [Function: hasOwnProperty]

app.enabled('hasOwnProperty');
// => true

After:

app.get('hasOwnProperty');
// => undefined

app.enabled('hasOwnProperty');
// => false

See #4802 for more details.

*/

var hasOwnProperty = Object.prototype.hasOwnProperty;
var hasOwnProperty = require('../utils').hasOwnProperty;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't strictly related, but I figured we could use the new utility. Happy to revert.

@EvanHahn
Copy link
Contributor Author

No rush on my end, but let me know if you'd like me to do anything with this PR.

@dougwilson dougwilson mentioned this pull request Feb 19, 2022
20 tasks
@dougwilson dougwilson force-pushed the ignore-settings-on-object-prototype branch from 5d0ff99 to 99043f5 Compare February 19, 2022 05:12
@dougwilson dougwilson added this to the 4.18 milestone Feb 19, 2022
@dougwilson dougwilson changed the base branch from master to 4.18 February 21, 2022 01:05
@dougwilson dougwilson force-pushed the ignore-settings-on-object-prototype branch from 99043f5 to 2ddae30 Compare February 21, 2022 01:06
Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! i did end up removing the utils thing since we eventually want to get rid of utils and the only thing it was shared with, the router, was removed in 5.x anyway.

@dougwilson dougwilson merged commit 2ddae30 into expressjs:4.18 Feb 21, 2022
@EvanHahn EvanHahn deleted the ignore-settings-on-object-prototype branch February 21, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants