New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
res.clearCookie() now ignores maxAge #4852
base: master
Are you sure you want to change the base?
Conversation
Testing the changes, in the unit-test:
confirms the
Great, cookies are not set in the raw http response! Due to my little experience in our test suite, another PR would be useful. But to my understanding things are looking good. |
var app = express(); | ||
|
||
app.use(function(req, res){ | ||
res.clearCookie('sid', { path: '/admin', maxAge: 900 }).end(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// ... blah blah blah
[Symbol(kOutHeaders)]: [Object: null prototype] {
'x-powered-by': [ 'X-Powered-By', 'Express' ],
'set-cookie': [
'Set-Cookie',
'sid=; Path=/admin; Expires=Thu, 01 Jan 1970 00:00:00 GMT'
]
}
}
.get('/') | ||
.expect('Set-Cookie', 'sid=; Path=/admin; Expires=Thu, 01 Jan 1970 00:00:00 GMT') | ||
.expect(200, done) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Takes the shape:
// ... blah blah blah
_maxListeners: undefined,
_enableHttp2: false,
_agent: false,
_formData: null,
method: 'GET',
url: 'http://127.0.0.1:46159/',
_header: {},
header: {},
writable: true,
_redirects: 0,
_maxRedirects: 0,
cookies: '',
// ... blah blah blah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- I was able to verify the expected raw http outputs
eb10dba
to
340be0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
This pr fixes #4851.
I have ...