Use object with null prototype for various app properties #4861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHahn
commented
Mar 17, 2022
3imed-jaberi
approved these changes
Apr 2, 2022
|
This has been open for over a year. No rush from me, but let me know if there's anything I can do to move this along. |
UlisesGascon
approved these changes
Feb 4, 2024
wesleytodd
approved these changes
Mar 14, 2024
33 tasks
|
I could work with the conflicts in this PR, but I do not have write access. |
`app.cache`, `app.engines`, and `app.settings` are now created with
`Object.create(null)` instead of `{}`.
This also updates a test to ensure that `app.locals` is created the same
way.
EvanHahn
force-pushed
the
object.create-null-for-various-properties
branch
from
a2348c8
to
68d1b9e
Compare
|
Fixed the merge conflict. I think this is now ready to be merged. |
UlisesGascon
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion here.
app.cache,app.engines, andapp.settingsare now created withObject.create(null)instead of{}.This also adds a test that
app.localsis created the same way.