Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: add yoda and no-cond-assign eslint rules #5253

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

robkebab
Copy link

Slightly improves readability in my opinion :) Feel free to reject if the community doesn't feel the same.

  • Improve consistency of the code.
  • Remove conditionals where the literal comes first (e.g. 'GET' !== method). Yoda rule reference for why this is generally suggested.
  • Remove assignment in conditionals (goes hand-in-hand with no yoda). No-cond-assignment rule reference for why this is generally suggested.

@robkebab robkebab changed the title Add yoda and no-cond-assign eslint rules Improvement: add yoda and no-cond-assign eslint rules Aug 29, 2023
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robkebab!

I appreciate your efforts in improving the code readability – it's definitely a step in the right direction. 🥳

However, it appears that there are issues with the CI for Node.js 8 and 9. From my observation, it seems like there might be errors with the CI machine, as some tests are marked as 'pending' without providing a clear pass or fail status.

Screenshot 2023-11-11 at 11 54 39

I am not able to re-run the CI due permissions, @dougwilson can you run them again? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants