Fix 404 error for edit on github #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougwilson
force-pushed
the
ts-fix-edit-on-github
branch
2 times, most recently
from
1fc4c7b
to
2b4a742
Compare
dougwilson
approved these changes
Apr 22, 2019
dougwilson
force-pushed
the
ts-fix-edit-on-github
branch
from
2b4a742
to
4727554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can also access api.html page through
/<language>/api.htmlFor this case, the
edit on githubwas sending us tobranchPath + '/tree/gh-pages/_includes/api/en/'+ 'en'.I have made an appropriate change to detect whether we are on
/<laguage>/api.htmlor/<language>/<version>/api.html, and create URL based on that.#924