document path-to-regexp change in express 5 migration guide #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pre-req: pillarjs/router#42 |
This was referenced Mar 9, 2020
blakeembrey
reviewed
Mar 13, 2020
|
one approval, and this is should be ready to go in! |
LinusU
approved these changes
Mar 20, 2020
@LinusU - from your approval, I am assuming that this comment is not a blocker? @expressjs/express-tc - this is all set to land, towards express 5 GA. Is there anyone with spare bandwidth to review and merge this? |
jonchurch
reviewed
Mar 23, 2020
Correct 👍 Although @jonchurch have now provided an extend description which I think we should use 👏 |
jonchurch
approved these changes
Mar 24, 2020
|
I believe we need to wait for the express release with this change to be published prior to landing on the site (i.e. 5.0.0-beta.1) |
dougwilson
force-pushed
the
gh-pages
branch
18 times, most recently
from
2a21f19
to
00062c1
Compare
dougwilson
force-pushed
the
gh-pages
branch
2 times, most recently
from
bb4652e
to
726bf05
Compare
dougwilson
force-pushed
the
express5_migration
branch
from
da3de79
to
4cea036
Compare
dougwilson
pushed a commit
that referenced
this pull request
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.