adding documentation around using promises in middleware #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryhinchey
force-pushed
the
promise-middleware-docs
branch
from
81734c8
to
0389f61
Compare
jonchurch
reviewed
Apr 5, 2020
dougwilson
reviewed
Apr 6, 2020
wesleytodd
reviewed
Apr 6, 2020
ryhinchey
force-pushed
the
promise-middleware-docs
branch
from
5ac2647
to
4faec7c
Compare
dougwilson
reviewed
Apr 17, 2020
dougwilson
reviewed
Apr 17, 2020
|
thanks for the review @dougwilson! I committed your suggestions 😄 |
dougwilson
approved these changes
Apr 22, 2020
dougwilson
force-pushed
the
promise-middleware-docs
branch
2 times, most recently
from
a1ffe14
to
cfd9e4c
Compare
|
squashed & merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the task here #1126
Closes #1109