Add Node Interactive details #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacksparrow
force-pushed
the
node-interactive
branch
from
0fba032
to
bdefa47
Compare
|
@expressjs/express-tc ok, this is ready to be reviewed and merged. Tested on Firefox, Chrome, and Safari. Optimized for mobile devices. It should most likely be fine on Edge too. Apart from adding the Node Interactive section, I have cleaned up the footer, and added the current version number next to the "Express" header. @crandmck It would be great if we can get it reviewed and merged today in your morning. Corresponding issue: #737 |
|
LGTM, thanks @hacksparrow |
|
I'm going to create an issue to remind us to remove this after the conference. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS, DO NOT MERGE!
You can take a look at what's coming up, on this PR/branch.