Color Status Token

[frankydp]

Just an additional default token for colorized status codes. Not sure if it would be wanted or useful.

[dougwilson]

Thanks! The concept seems fine, just a few issues:

1. The changes do not even compile. All tests are red due to the inability to now even require() the script. Please take a look into this issue.
2. There are no tests for the added token, please add complete tests for app possible branches of the token :)
3. There is no documentation added to the README for the token, so that would be sweet to get added as well :)

In addition to this, this PR should also DRY up the dev format as well. Probably the code for this new token should be the exact same color code from the dev format instead of some other code, and the format can just use this token and then get smashed down into just being a string like the other formats are.

[frankydp]

Thanks for the feedback. I will get the details hashed out and resub.

[dougwilson]

Cool :) Just update this pull request with the new changes and ping me when they are included and I'll take another look :)

[frankydp]

@dougwilson Dried up the dev compile to the string format. Added test for new token, and corrected test for dev to account for the resulting changes to responses, left in the color test in dev even though they were a little redundant. Added colorstatus token to docs. Also, changed the color code to be more inline with the original implementation from dev. Sorry if there was any build spam.

[dougwilson]

Please add documentation about which statuses get which colors.

[artis3n]

The last comment on this was on May 28. Is this still on track to being implemented @frankydp? Seems like a revert of a removed test is still pending.

[frankydp]

@arikalfus Revert was committed, with a clear added to accommodate, back on May 28th. Pull seems to have conflicts now though.

[dougwilson]

Hi @frankydp , sorry, until very recently GitHub did not send any notice when PRs where updated, so since your last update you never posted a comment, I didn't realize you pushed anything else, very sorry for the misunderstanding!

Looking over the PR, there are still a few issues to be resolved:

1. Every line in the :dev format seems to now be starting with a space character where before the first letter of the method was the first character. You should probably remove that space character.
2. The documentation for :colorstatus is confusing. It sounds like it's just the colorized :status token, but if I override that token to do something different, :colorstatus does not seem to be affected.
3. It doesn't seem like you reverted those tests that I asked earlier, as they are still showing as altered in the current diff (one line was changed and another line was removed). Can you put them back to how they were, please?

[dougwilson]

Closing the PR since I never heard back and there are conflicts that prevent merging.