Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: priority cookies #884

Closed
mlucool opened this issue Apr 14, 2022 · 5 comments · Fixed by #939
Closed

Feature Request: priority cookies #884

mlucool opened this issue Apr 14, 2022 · 5 comments · Fixed by #939

Comments

@mlucool
Copy link
Contributor

mlucool commented Apr 14, 2022

Hi,

cookie has recently been released to allow for users to set the priority cookie (jshttp/cookie#138). This is important to set for session cookies due to the corresponding issued log in https://bugs.chromium.org/p/chromium/issues/detail?id=1309656 where users session cookies may be deleted.

Can we support passing through this attribute similar to other cookie properties?

@mlucool
Copy link
Contributor Author

mlucool commented Apr 27, 2022

Hi,

I see this is now labeled as an enhancement and not just "discuss". Would you be open to PR for this feature or is someone already planning to do this?

@dougwilson
Copy link
Contributor

Hi @mlucool sorry, I did start on this, but then forgot about it. I'll get that added here 👍

@mlucool
Copy link
Contributor Author

mlucool commented Jun 28, 2022

Hi @dougwilson - just checking in again. Anything I can do to help move this along?

@mlucool
Copy link
Contributor Author

mlucool commented Dec 7, 2022

Hi. Just checking in again @dougwilson. Happy to make a PR here.

mlucool added a commit to mlucool/session that referenced this issue May 1, 2023
This adds cookie.priority by passing this property through to
cookie (which requires us to upgrade cookie to >=0.5.0).

The priority option is not fully standardized, but has been
proposed and in-use since 2016.

See also: jshttp/cookie#138
Fixes: expressjs#884
@mohsinulhaq
Copy link

@dougwilson would it be possible to get this one going? The PR has been pending for so long with no comments. Let me know if I should direct my queries to someone else instead. :)

dougwilson pushed a commit to mlucool/session that referenced this issue Dec 12, 2023
This adds cookie.priority by passing this property through to
cookie (which requires us to upgrade cookie to >=0.5.0).

The priority option is not fully standardized, but has been
proposed and in-use since 2016.

See also: jshttp/cookie#138
Fixes: expressjs#884
dougwilson pushed a commit to mlucool/session that referenced this issue Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants