Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webview packaging issue on the GitHub CI #1

Closed
Daru13 opened this issue Jun 2, 2022 · 1 comment
Closed

Webview packaging issue on the GitHub CI #1

Daru13 opened this issue Jun 2, 2022 · 1 comment
Assignees
Labels
bug Something isn't working ci This issue is related to the CI provided by GitHub Workflows

Comments

@Daru13
Copy link
Collaborator

Daru13 commented Jun 2, 2022

There seems to be an issue with the GitHub Workflow that builds and package the extension after each commit: Rollup fails at resolving a path, and therefore fails at bundling the webview into a single HTML file. For this reason, the VS Code extension that can be downloaded from this repository is not working at the moment, as it is unable to load the file when creating the webview, which remains empty (out/webview/webview.inlined.html).

I do not experience this bug locally. Maybe it has to do with the version of Rollup used in the GitHub Workflow?

The exact error is visible in the logs of the GitHub Workflow, in the Build i-LaTeX step, e.g., https://github.com/exsitu-projects/ilatex/runs/6223585813?check_suite_focus=true.

@Daru13 Daru13 added bug Something isn't working ci This issue is related to the CI provided by GitHub Workflows labels Jun 2, 2022
@Daru13 Daru13 self-assigned this Jun 2, 2022
Daru13 added a commit that referenced this issue Jan 30, 2024
This includes fixes for GitHub issues #1 to #3, which are resolved by the last few commits.
@Daru13
Copy link
Collaborator Author

Daru13 commented Jan 30, 2024

The issue was caused by a typo in the path to cropperjsApi, which caused Rollup to fail remotely, but not locally—perhaps because MacOS does not deal with case-sensitive paths the same way Ubuntu does. It was fixed by ec6af8f.

@Daru13 Daru13 closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci This issue is related to the CI provided by GitHub Workflows
Projects
None yet
Development

No branches or pull requests

1 participant