Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Clean up language files #471

Closed
rintisch opened this issue Apr 7, 2024 · 0 comments · Fixed by #472 or rintisch/cart#13
Closed

[TASK] Clean up language files #471

rintisch opened this issue Apr 7, 2024 · 0 comments · Fixed by #472 or rintisch/cart#13
Assignees

Comments

@rintisch
Copy link
Sponsor Collaborator

rintisch commented Apr 7, 2024

Feature Request

Is your feature request related to a problem? Please describe.
The content of the language files (XLIFF files) is not throughout logical. The usage of locallang.xlf, locallang_be.xlf and locallang_be.xlf is not limited to its domain and especially locallang.xlf contains a lot of entries that are never used. This makes it harder for contributors to translate to new languages.

Furthermore does the BE view use entries which are used in the frontend which makes it hard for other developer to only overwrite backend labels without changing front labels (and vice versa).

Describe the solution you'd like

  • Every language files has it's clear domain.
  • No unused entries in the files.
  • Labels which are used in the backend are used from the locallang.xlf but have their own entries which are namespaced with e.g. tx_cart.backend.*.

This will be a follow up of #465 and can only be merged after this was merged.

@rintisch rintisch self-assigned this Apr 7, 2024
rintisch added a commit to rintisch/cart that referenced this issue Apr 7, 2024
Adapt the message when the module is used on a
page without order items. Furhtermore show a
correct message when the filtered search results
in zero results.

Solves extcode#471
rintisch added a commit to rintisch/cart that referenced this issue Apr 19, 2024
Adapt the message when the module is used on a
page without order items. Furhtermore show a
correct message when the filtered search results
in zero results.

Solves extcode#471
rintisch added a commit to rintisch/cart that referenced this issue May 22, 2024
* [TASK] Clean up entries of locallang_db.xlf

`locallang_db.xlf` contains only labels for TCA
and FlexForms.

Superfluous entries are deleted.

Harmonize spelling of email (always without
hyphen).

* [TASK] Clean up `locallang.xlf`

Delete not used entries

* [TASK] Separate language keys of BE templates

The backend list view uses its own
entries from `locallang.xlf` which are namespaced.

EXCEPTION: The entries for status of shipping and
payment are still shared. But it's unlikely that
developer might want to change them.

* [TASK] Show correct message when wrong page

Adapt the message when the module is used on a
page without order items. Furhtermore show a
correct message when the filtered search results
in zero results.

Solves extcode#471

* [TASK] Add labels for multi-step checkout

Add missing labels for the buttons which are used
to move between the steps in a multi-step
checkout setup.
extcode pushed a commit that referenced this issue May 24, 2024
* [TASK] Clean up entries of locallang_db.xlf

`locallang_db.xlf` contains only labels for TCA
and FlexForms.

Superfluous entries are deleted.

Harmonize spelling of email (always without
hyphen).

* [TASK] Clean up `locallang.xlf`

Delete not used entries

* [TASK] Separate language keys of BE templates

The backend list view uses its own
entries from `locallang.xlf` which are namespaced.

EXCEPTION: The entries for status of shipping and
payment are still shared. But it's unlikely that
developer might want to change them.

* [TASK] Show correct message when wrong page

Adapt the message when the module is used on a
page without order items. Furhtermore show a
correct message when the filtered search results
in zero results.

* [TASK] Add labels for multi-step checkout

Add missing labels for the buttons which are used
to move between the steps in a multi-step
checkout setup.

Solves #471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant