Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Update CSS and HTML in BE view #466

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

rintisch
Copy link
Sponsor Collaborator

@rintisch rintisch commented Mar 28, 2024

  • Use TYPO3-native date input fields.
  • Payment and shipping get background colors depending on their status.
  • Use TYPO3-native layout functionality.
  • Remove inline CSS
  • Restyle list view (update filters, pagination)
  • Restyle order view
  • Add changelog for new TypoScript option for search date format
  • Update docs for TypoScript search date format

Fixes #465

@rintisch rintisch requested a review from extcode March 28, 2024 13:28
@rintisch rintisch force-pushed the task/issue-465-update-css-html-in-be branch 2 times, most recently from a6d1da7 to c9e99b2 Compare March 28, 2024 13:42
@rintisch
Copy link
Sponsor Collaborator Author

rintisch commented Mar 28, 2024

@extcode Could you have a look at the new styling and give me feedback what you think about it?

I'm not happy with the mixed usage of translations. The BE uses entries from locallang.xlf instead of using locallang_be.xlf. Imo this should be refactored.

@extcode
Copy link
Owner

extcode commented Apr 1, 2024

This is a nice improvement. I would prefer to have more spacing in the table for the order data.

@rintisch
Copy link
Sponsor Collaborator Author

rintisch commented Apr 1, 2024

Thanks for the feedback.
The data order table is styled as TYPO3 recommends it (screenshot from Styleguide)
image

Nevertheless: I doubled the spacing.

I will fulfill the open todo of the PR. How should we handle the usage of entries from locallang.xlf in the BE? Should they move as copy to locallang_be.xlf? Otherwise developer who only want to override a BE label might have a problem...

@rintisch rintisch force-pushed the task/issue-465-update-css-html-in-be branch 2 times, most recently from 8a85a27 to a751ae4 Compare April 1, 2024 18:40
@extcode
Copy link
Owner

extcode commented Apr 1, 2024

Let‘s copy the necessary to an own translation file.

@rintisch
Copy link
Sponsor Collaborator Author

rintisch commented Apr 1, 2024

I must admit that I do not really understand the intention behind locallang_be.xlf and locallang_db.xlf. I cannot see a scheme. Is it necessary to have both? Can they be merged?

@rintisch rintisch force-pushed the task/issue-465-update-css-html-in-be branch 2 times, most recently from b42231a to 4b0d991 Compare April 7, 2024 10:50
@rintisch rintisch changed the title WIP [TASK] Update CSS and HTML in BE view [TASK] Update CSS and HTML in BE view Apr 7, 2024
@rintisch
Copy link
Sponsor Collaborator Author

rintisch commented Apr 7, 2024

@extcode I will make the language files clean ups in #471 because this will need a breaking changelog entry. Having it on it's on issue makes it easier for users to update.

@rintisch rintisch force-pushed the task/issue-465-update-css-html-in-be branch 3 times, most recently from 399d49f to 5e50f8f Compare April 7, 2024 14:51
@rintisch rintisch marked this pull request as ready for review April 7, 2024 14:51
@rintisch rintisch force-pushed the task/issue-465-update-css-html-in-be branch from 5e50f8f to 34a6e95 Compare April 7, 2024 15:12
* Use TYPO3-native date input fields.
* Payment and shipping get background colors
  depending on their status.
* Use TYPO3-native layout functionality.
* Remove inline CSS
* Restyle list view (update filters, pagination)
* Restyle order view
* Date format in backend can be set via TypoScript
* Add changelog for new TypoScript option for
  backend date format
* Update docs for TypoScript backend date format
@rintisch rintisch force-pushed the task/issue-465-update-css-html-in-be branch from 34a6e95 to 5ad44b3 Compare April 7, 2024 15:21
@extcode extcode merged commit b0eef74 into extcode:main Apr 12, 2024
8 checks passed
@rintisch rintisch deleted the task/issue-465-update-css-html-in-be branch May 22, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Update CSS and HTML in Backend
2 participants