-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with memory helper in early 2.3 #18
Comments
@jissereitsma I believe you already ran into this prior, but it looks like the patch we apply may be for something else? Thinking that maybe we exclude the memory test from the shipped phpunit.xml? |
The broken 2.3.0 run seems due to a wrong MSI package being published somewhere. Not sure how to fix this, except from removing that The memory issue with 2.3.1 to 2.3.3 is indeed an issue that I fixed earlier with a patch here: https://github.com/extdn/github-actions-m2/blob/master/magento-integration-tests/entrypoint.sh#L110 But it was not due to a single test, it was due to the reporting of memory usage of all tests, after running all tests. The code of this memory helper contains some dark magic for Window vs Linux, but still made wrong assumptions. However, I believe that error explicitly mentioned |
If this is early 2.3 only, I think we can close this as won't fix. |
yeap being realistic here |
There are a couple of M2 core issues
2.3.0 is broken due to
see https://github.com/extdn/extension-dashboard-m2/runs/1312019553?check_suite_focus=true
2.3.1 - 2.3.3
broken due to
https://github.com/extdn/extension-dashboard-m2/runs/1312039797?check_suite_focus=true
see https://github.com/extdn/extension-dashboard-m2/runs/1312423133?check_suite_focus=true
The text was updated successfully, but these errors were encountered: