Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit dll exports on windows #212

Merged

Conversation

Ilia-Kosenkov
Copy link
Member

Closes #211.
When scaffolding a package to use with extendr, also emit a <packagename>-win.def file with exports to avoid exporting too many symbols on Windows.

@Ilia-Kosenkov Ilia-Kosenkov marked this pull request as ready for review November 14, 2022 16:36
inst/templates/win.def Outdated Show resolved Hide resolved
Copy link
Member

@CGMossa CGMossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Ilia-Kosenkov Ilia-Kosenkov merged commit 36e145f into extendr:main Nov 16, 2022
@Ilia-Kosenkov Ilia-Kosenkov deleted the 211-Limit-dll-exports-on-Windows branch April 20, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x86_64-w64-mingw32.static.posix\bin/ld.exe linker cannot handle large rust crates
3 participants