fix value field duplication issue

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
external-secrets · Feb 8, 2024 · b062162 · b062162
1 parent c68d798
commit b062162
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/e2e/suites/provider/cases/template/template.go b/e2e/suites/provider/cases/template/template.go
@@ -165,6 +165,7 @@ func genericPushSecretTemplate(f *framework.Framework) (string, func(*framework.
 
 			// create an external secret that fetches the created remote secret
 			// and check the value
+			exampleOutput := "example-output"
 			es := &esv1beta1.ExternalSecret{
 				ObjectMeta: metav1.ObjectMeta{
 					Name:      "e2e-es",
@@ -176,11 +177,11 @@ func genericPushSecretTemplate(f *framework.Framework) (string, func(*framework.
 						Name: f.Namespace.Name,
 					},
 					Target: esv1beta1.ExternalSecretTarget{
-						Name: "example-output",
+						Name: exampleOutput,
 					},
 					Data: []esv1beta1.ExternalSecretData{
 						{
-							SecretKey: "example-output",
+							SecretKey: exampleOutput,
 							RemoteRef: esv1beta1.ExternalSecretDataRemoteRef{
 								Key: "key",
 							},
@@ -196,7 +197,7 @@ func genericPushSecretTemplate(f *framework.Framework) (string, func(*framework.
 			err = wait.PollImmediate(time.Second*5, time.Second*15, func() (bool, error) {
 				err := f.CRClient.Get(context.Background(), types.NamespacedName{
 					Namespace: f.Namespace.Name,
-					Name:      "example-output",
+					Name:      exampleOutput,
 				}, outputSecret)
 				if apierrors.IsNotFound(err) {
 					return false, nil
@@ -205,7 +206,7 @@ func genericPushSecretTemplate(f *framework.Framework) (string, func(*framework.
 			})
 			gomega.Expect(err).ToNot(gomega.HaveOccurred())
 
-			v, ok := outputSecret.Data["example-output"]
+			v, ok := outputSecret.Data[exampleOutput]
 			gomega.Expect(ok).To(gomega.BeTrue())
 			gomega.Expect(string(v)).To(gomega.Equal("executed: BAR"))
 		}

diff --git a/pkg/provider/testing/fake/fake.go b/pkg/provider/testing/fake/fake.go
@@ -16,7 +16,6 @@ package fake
 
 import (
 	"context"
-	"fmt"
 
 	corev1 "k8s.io/api/core/v1"
 	"sigs.k8s.io/controller-runtime/pkg/client"
@@ -82,7 +81,6 @@ func (v *Client) GetAllSecrets(ctx context.Context, ref esv1beta1.ExternalSecret
 }
 
 func (v *Client) PushSecret(_ context.Context, secret *corev1.Secret, data esv1beta1.PushSecretData) error {
-	fmt.Println("CALLING PUSH SECRET: ", secret.Data, data)
 	v.SetSecretArgs[data.GetRemoteKey()] = SetSecretCallArgs{
 		Value:     secret.Data[data.GetSecretKey()],
 		RemoteRef: data,