Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in ExtermalSecretRewriteTransform #2917

Closed
shuheiktgw opened this issue Dec 1, 2023 · 2 comments · Fixed by #2919
Closed

Fix typo in ExtermalSecretRewriteTransform #2917

shuheiktgw opened this issue Dec 1, 2023 · 2 comments · Fixed by #2919
Assignees
@Kiyo510
Labels
good first issue Good for newcomers kind/bug Categorizes issue or PR as related to a bug.

Comments

@shuheiktgw
Copy link
Contributor

shuheiktgw commented Dec 1, 2023 •
edited

Describe the bug
ExtermalSecretRewriteTransform should have been ExternalSecretRewriteTransform...
@shuheiktgw shuheiktgw added kind/bug Categorizes issue or PR as related to a bug. good first issue Good for newcomers labels Dec 1, 2023
@Kiyo510
Copy link
Contributor

Kiyo510 commented Dec 2, 2023

Hello.
This is my first contribution to OSS.

Can I work on this issue?

@moolen
Copy link
Member

moolen commented Dec 2, 2023

Sure thing, assigned it to you ❤️
Let me know if you need any help

Kiyo510 added a commit to Kiyo510/external-secrets that referenced this issue Dec 2, 2023
@Kiyo510
typo: ref:external-secrets#2917 Fix typo in ExtermalSecretRewriteTran…
c4ff206 
…sform
Kiyo510 added a commit to Kiyo510/external-secrets that referenced this issue Dec 2, 2023
@Kiyo510
Signed-off-by: Kiyo510 <miraishida00510@gmail.com>
44e1791 
 typo: ref:external-secrets#2917 Fix typo in ExtermalSecretRewriteTransform
@Kiyo510 Kiyo510 mentioned this issue Dec 2, 2023
Merged
5 tasks
moolen pushed a commit that referenced this issue Dec 2, 2023
@Kiyo510
Signed-off-by: Kiyo510 <miraishida00510@gmail.com> (#2919)
2f043ec 
typo: ref:#2917 Fix typo in ExtermalSecretRewriteTransform
limistah pushed a commit to Onboardbase/external-secrets that referenced this issue Jan 8, 2024
@Kiyo510 @limistah
Signed-off-by: Kiyo510 <miraishida00510@gmail.com> (external-secrets#…
6684764 
…2919)

typo: ref:external-secrets#2917 Fix typo in ExtermalSecretRewriteTransform
Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>
charan986 pushed a commit to charan986/external-secrets that referenced this issue Jan 22, 2024
@Kiyo510
Signed-off-by: Kiyo510 <miraishida00510@gmail.com> (external-secrets#…
23067e9 
…2919)

typo: ref:external-secrets#2917 Fix typo in ExtermalSecretRewriteTransform
Signed-off-by: Sai Charan Godasi <saicharangodasi@Sais-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kiyo510 Kiyo510

Labels
good first issue Good for newcomers kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

typo: ref:#2917 Fix typo in ExtermalSecretRewriteTransform Kiyo510/external-secrets
3 participants
@moolen @shuheiktgw @Kiyo510