Implements DecodingStrategy. #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👇 Click on the image for a new way to code review
Legend |
gusfcarvalho
force-pushed
the
feature/decodingstrategy
branch
from
16d62a7
to
1b0aad0
Compare
knelasevero
reviewed
Jun 25, 2022
gusfcarvalho
changed the title
Fixes #920 Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
gusfcarvalho
force-pushed
the
feature/decodingstrategy
branch
2 times, most recently
from
a69de38
to
f5bc282
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
/approve |
![paul-the-alien[bot]](https://avatars.githubusercontent.com/in/83809?s=60&v=4){kind=small}
|
I will leave this one open so other people can jump in and take a look :) |
|
@moolen we already merged as you are on vacations, but feel free to open up issues if you spot something weird here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed solution to implement DecodingStrategy, with some strategies available for base64 and base64url encoding formats.
Current implementation defaults to
None, in order to preserve current External Secrets behavior, as some secret values might get misconverted to base64 due to their nature (for instance, numbered values).Fixes #920
Signed-off-by: Gustavo Carvalho gustavo.carvalho@container-solutions.com