Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to configure cert lookahead interval for webhook pod #1304

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

gusfcarvalho
Copy link
Member

Fixes #1249

Signed-off-by: Gustavo Carvalho gustavo.carvalho@container-solutions.com

Fixes #1249

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
@ghost
Copy link

ghost commented Jun 27, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@gusfcarvalho gusfcarvalho force-pushed the fix/allow-webhook-cert-validity-period branch from 33bbcae to 0d9b88d Compare June 27, 2022 17:30
@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@knelasevero
Copy link
Member

/approve

@gusfcarvalho gusfcarvalho merged commit ccea3d5 into main Jul 12, 2022
@paul-the-alien paul-the-alien bot deleted the fix/allow-webhook-cert-validity-period branch July 12, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook only works when certificates are valid for longer than 90 days.
2 participants