docs: adds Helm docs for dockerconfigjson template

[cebidhem]

Hey there,

I'd like to propose this PR to put in the docs what has been discussed in the issue #972.
Indeed, Helm convert the example as nil and @moolen gave a solution in this comment #972 (comment) that should be written in the docs in my opinion.

Thanks for reviewing.

[paul-the-alien]

Greetings!
Thank you for contributing to this project!
If this is your first time contributing, please make
sure to read the Developer and Contributing Process guides.
Please also mind and follow our Code of Conduct.

Useful commands:

• make fmt: Formats the code
• make check-diff: Ensures the branch is clean
• make reviewable: Ensures a PR is ready for review

[ghost]

👇 Click on the image for a new way to code review

• Make big changes easier — review code in small groups of related files

• Know where to start — see the whole change at a glance

• Take a code tour — explore the change with an interactive tour

• Make comments and review — all fully sync’ed with github

  Try it now!

Legend

[gusfcarvalho]

Hi @cebidhem ! thanks for your contribution

[gusfcarvalho]

I think this can be of great value to our doc! Just a little nit as this is just one of the possible ways to do it.

Also, I think referencing the general issue can be a good idea 😄

[cebidhem]

I think this can be of great value to our doc! Just a little nit as this is just one of the possible ways to do it.

Also, I think referencing the general issue can be a good idea 😄

Thanks for the tips in the review. I made the suggested changes, but I'm trying to figure out why this second commit isn't verified while the first was :)

Edit: commit is now verified, I don't what happened with the git.user .... sorry about that

[gusfcarvalho]

I also have no idea! Did you commit using GitHub UI?

[gusfcarvalho]

Oh I know why, when using make docs currently the configuration for the repo (user and email) gets changed. This last commit was under “Doc docs@external-secrets.io

[gusfcarvalho]

I think you can git config user.name git config user.email and then amend and resign the commit. Force pushing it should be fine

[gusfcarvalho]

Or you can just Squash it :)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[cebidhem]

Indeed it was the make docs when I was testing it.

Squashed everything!

Thanks for taking the time!

[gusfcarvalho]

/approve

[gusfcarvalho]

/merge

[gusfcarvalho]

/merge