Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid YAML error when using extraVolumeMounts / extraVolumes #1311

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

mhahl
Copy link
Contributor

@mhahl mhahl commented Jun 30, 2022

When setting webhook.extraMounts or webhook.extraVolumeMounts while deploying the operator or helm chart it would fail with the following message:

Error: YAML parse error on external-secrets/templates/webhook-deployment.yaml: error converting YAML to JSON: yaml: line 52: did not find expected key
helm.go:81: [debug] error converting YAML to JSON: yaml: line 52: did not find expected key

This change aligns the indentation so setting the options no longer fail.

Copy link
Contributor

@paul-the-alien paul-the-alien bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings!
Thank you for contributing to this project!
If this is your first time contributing, please make
sure to read the Developer and Contributing Process guides.
Please also mind and follow our Code of Conduct.

Useful commands:

  • make fmt: Formats the code
  • make check-diff: Ensures the branch is clean
  • make reviewable: Ensures a PR is ready for review

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ghost
Copy link

ghost commented Jun 30, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@gusfcarvalho
Copy link
Member

Hey @mhahl thank you for your contribution!

@gusfcarvalho
Copy link
Member

/approve

@gusfcarvalho
Copy link
Member

/merge

@gusfcarvalho gusfcarvalho merged commit 03da357 into external-secrets:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants