Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typos #2042

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Fixed typos #2042

merged 1 commit into from
Feb 23, 2023

Conversation

bvdboom
Copy link
Contributor

@bvdboom bvdboom commented Feb 22, 2023

Problem Statement

Typos I came across.

Related Issue

N/A

Proposed Changes

N/A

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

@bvdboom bvdboom requested a review from a team as a code owner February 22, 2023 20:36
@bvdboom bvdboom requested review from gusfcarvalho and removed request for a team February 22, 2023 20:36
paul-the-alien[bot]
paul-the-alien bot reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@paul-the-alien paul-the-alien bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings!
Thank you for contributing to this project!
If this is your first time contributing, please make
sure to read the Developer and Contributing Process guides.
Please also mind and follow our Code of Conduct.

Useful commands:

  • make fmt: Formats the code
  • make check-diff: Ensures the branch is clean
  • make reviewable: Ensures a PR is ready for review

@bvdboom
Typos
bcf17fe 
Signed-off-by: bvdboom <bvdboom@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

moolen
moolen approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@moolen moolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing those, much appreciated ❤️

@moolen moolen merged commit 13f26e6 into external-secrets:main Feb 23, 2023
limistah pushed a commit to Onboardbase/external-secrets that referenced this pull request Feb 27, 2023
@bvdboom @limistah
📖 fix typo (external-secrets#2042)
bf2dffc 
Signed-off-by: bvdboom <bvdboom@users.noreply.github.com>
Co-authored-by: Bernard <bv.local>
Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-the-alien paul-the-alien[bot] paul-the-alien left review comments

@moolen moolen moolen approved these changes

@gusfcarvalho gusfcarvalho Awaiting requested review from gusfcarvalho gusfcarvalho is a code owner automatically assigned from external-secrets/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bvdboom @moolen